Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* supermin support for FrugalWare (pacman-g2) #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DeX77
Copy link
Contributor

@DeX77 DeX77 commented Oct 20, 2013

This is an initial implementation for FrugalWare support for supermin.

@ptoscano
Copy link
Contributor

Thanks for your interest in supermin, and sorry for the late reply.

This work was done on supermin 4.x. Earlier this year, supermin has been rewritten, and the 5.x series has a slightly different, but simplier, interface for package handlers.

Regarding your patch:

  • pacman-g2 is already detected at configure, just used to not enable the pacman handler for FrugalWare
  • you don't need to disable the pacman configure check, just make sure that the ph_detect implementation for your package handler returns true only on your distro; in particular, the logic you did seems enough for this
  • do not assume fakeroot is available, but make sure to use Config.fakeroot and have its existance checked in your ph_detect implementation (see pacman_detect in pacman.ml for example)
  • maybe you can make use of some of the implementations for pacman also for pacman-g2, but that's up to you

When updating this patches for supermin 5.x, make sure that make check runs fine, so you know that the package handler implementation is correctly detected and works fine. Remember to add support for your distro also in tests/test-harder.sh, which can do some more file presence testing (it is skipped on unknown distros).

Please note supermin's development happens mostly on the libguestfs mailing list, see https://www.redhat.com/mailman/listinfo/libguestfs, so patches should be sent there (we do not use github's pull requests features).

Looking forward to see the updated patch for this for supermin 5.x!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants