dequantizing splines #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Martin Bruse <zond@google.com>
mo271
force-pushed
the
dequantize_splines
branch
from
e6a4783 to
bb23e4c
Compare
veluca93
reviewed
Dec 11, 2024
veluca93
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Can you confirm the numbers with @eustas and/or @sboukortt ?
The numbers come directly from libjxl, I added tests that produce the same numbers, but I'll ask @sboukortt and @eustas to review. |
eustas
approved these changes
Dec 16, 2024
sboukortt
reviewed
Dec 16, 2024
Co-authored-by: Luca Versari <veluca93@gmail.com>
Co-authored-by: Martin Bruse <zond@google.com>
sboukortt
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.