chore(kad): rename substreams_timeout#6076
Merged
mergify[bot] merged 5 commits intolibp2p:masterfrom Jun 26, 2025
Merged
Conversation
jxs
reviewed
Jun 26, 2025
Member
jxs
left a comment
There was a problem hiding this comment.
Thanks Elena! LGTM left just one comment
elenaf9
commented
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#6015 made the timeout for outbound substreams in kademlia configurable by introducing a
outbound_substreams_timeoutconfig option.There is currently an open PR #6009 that plans to also apply that timeout to inbound substream, in which case we probably want toe rename the config option to
substreams_timeout(without the prefix).Because we plan to release soon and might not get #6009 in in-time, I propose that we already do the renaming now, to avoid breaking the API again with the next release.
Notes & open questions
I directly changed the initial changelog entry of #6009 to avoid confusion. Is that okay or should a add a separate changelog entry for the renaming?
Change checklist
I have added tests that prove my fix is effective or that my feature worksA changelog entry has been made in the appropriate crates