revise Noise spec & remove padding in payloads#212
Closed
yusefnapora wants to merge 4 commits intomasterfrom
Closed
revise Noise spec & remove padding in payloads#212yusefnapora wants to merge 4 commits intomasterfrom
yusefnapora wants to merge 4 commits intomasterfrom
Conversation
jxs
pushed a commit
to jxs/specs
that referenced
this pull request
Aug 8, 2025
* tweaking rust-libp2p permissions Signed-off-by: Dave Grantham <dwh@linuxprogrammer.org> * fix@8299816136 [skip fix] * removing Admin team from rust-libp2p repos admin list Signed-off-by: Dave Grantham <dwh@linuxprogrammer.org> --------- Signed-off-by: Dave Grantham <dwh@linuxprogrammer.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: libp2p-mgmt-read-write[bot] <104492852+libp2p-mgmt-read-write[bot]@users.noreply.github.com>
jxs
pushed a commit
to jxs/specs
that referenced
this pull request
Aug 8, 2025
This reverts commit 8119710.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has a few commits that I've been meaning to get up for a little while now; my attention has been a bit more fragmented than usual the past few weeks :)
The big substantive change is that the plaintext body of encrypted payloads no longer has a padding component - @raulk recommended we rethink this and I agree that it adds complexity for questionable benefit.
I also added a bit more context to Noise Pipes and tried to underscore that it's optional and might not be worth the complexity, especially if you're mostly doing request/reply style RPC calls.
Also added a future work section with some notes about QUIC and pre-shared keys.
I didn't address replay-ability or channel binding, since @raulk is working on that in #210