Conversation
yusefnapora
approved these changes
Jan 20, 2020
Contributor
yusefnapora
left a comment
yusefnapora
left a comment
There was a problem hiding this comment.
Nice, thanks for pulling this out of the earlier PR. I'll make a branch on the go implementation to update the protobuf field names.
bertrandfalguiere
suggested changes
Jan 20, 2020
mhchia
approved these changes
Jan 21, 2020
Contributor
mhchia
left a comment
mhchia
left a comment
There was a problem hiding this comment.
Looks good to me! May I also get added to the interest group? Thank you.
This PR simplifies protobuf field naming, and formalises in which Noise messages of IK and XX the message payload is to be shared, to guarantee secrecy, integrity and authentication.
raulk
force-pushed
the
noise-refinements
branch
from
8596f40 to
51d5ac6
Compare
Member
Author
|
@mhchia done, thanks! |
jxs
pushed a commit
to jxs/specs
that referenced
this pull request
Aug 8, 2025
* Removing biglep maintainer permissions on various repos * fix@10220223226 [skip fix] --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following from the discussion in #234, we've abandoned the "handshake seal" construction, as it is considered redundant. This PR carries forward the other changes introduced in that PR, for inclusion in the spec.
Concretely, this PR simplifies protobuf field naming, and formalises in which Noise messages of IK and XX the message payload is to be shared, to guarantee secrecy, integrity and authentication.
Since these changes have been reviewed in past iterations with no comments, I will merge this PR in 24h unless somebody screams.
ping: @shahankhatch @Mikerah @djrtwo @dryajov @mpetrunic @morrigan @araskachoi @mhchia