Skip to content

Sign builds #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joebowbeer merged 2 commits into from
Dec 7, 2025
+7 −7
Merged

Sign builds #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6b72de
Update signing configuration in build.gradle
joebowbeer Dec 7, 2025
3a86bbe
Enable signing for Gradle publish step
joebowbeer Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- if: github.event_name == 'push'
run: ./gradlew :PdCore:pd-core:publishToSonatype
env:
ORG_GRADLE_PROJECT_signingKey: ${{ secrets.SIGNING_KEY }}
ORG_GRADLE_PROJECT_signingPassphrase: ${{ secrets.SIGNING_PASSPHRASE }}
ORG_GRADLE_PROJECT_sonatypeUsername: ${{ secrets.SONATYPE_USERNAME }}
ORG_GRADLE_PROJECT_sonatypePassword: ${{ secrets.SONATYPE_PASSWORD }}
#ORG_GRADLE_PROJECT_signingKey: ${{ secrets.SIGNING_KEY }}
#ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.SIGNING_PASSWORD }}
10 changes: 5 additions & 5 deletions PdCore/pd-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ publishing {
}
}

// ossrh requires signed releases, but not snapshots.
// Maven Central requires signed releases, but not snapshots.
// This configures signing if a key is found.
// The following environment variables provide a signing key and passphrase:
// export ORG_GRADLE_PROJECT_signingKey=`cat private.pgp`
// export ORG_GRADLE_PROJECT_signingPassword="<passphrase>"
// export ORG_GRADLE_PROJECT_signingPassphrase="<passphrase>"
// After making the above available, you can try signing using
// ./gradlew signMavenPublication
def hasSigningKey = project.hasProperty('signingKeyId') || project.hasProperty('signingKey')
Expand All @@ -173,13 +173,13 @@ void sign(Project project) {
required { project.gradle.taskGraph.hasTask('required') }
def signingKeyId = project.findProperty('signingKeyId')
def signingKey = project.findProperty('signingKey')
def signingPassword = project.findProperty('signingPassword')
def signingPassphrase = project.findProperty('signingPassphrase')
if (signingKeyId) {
// use in-memory ascii-armored OpenPGP subkey
useInMemoryPgpKeys(signingKeyId, signingKey, signingPassword)
useInMemoryPgpKeys(signingKeyId, signingKey, signingPassphrase)
} else if (signingKey) {
// use in-memory ascii-armored key
useInMemoryPgpKeys(signingKey, signingPassword)
useInMemoryPgpKeys(signingKey, signingPassphrase)
}
sign publishing.publications.maven
}
Expand Down