Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-linear equality constraints in COBYLA #17

Merged
merged 16 commits into from
Oct 23, 2023
Merged

Conversation

emmt
Copy link
Collaborator

@emmt emmt commented Oct 20, 2023

@emmt
Copy link
Collaborator Author

emmt commented Oct 20, 2023

@zaikunzhang and @amontoison: Can you have a look at this PR before I merge it?

The musl Linux tests failed because of insufficient credits...

@amontoison
Copy link
Member

@zaikunzhang and @amontoison: Can you have a look at this PR before I merge it?

I suggest to add a reference to the Julia package NOMAD.jl.

The musl Linux tests failed because of insufficient credits...

I checked the logs and we have some StackOverflowError.
For information, we have unlimited credits with CirrusCI if the repository is public @emmt.

@emmt
Copy link
Collaborator Author

emmt commented Oct 20, 2023

I checked the logs and we have some StackOverflowError.
For information, we have unlimited credits with CirrusCI if the repository is public @emmt.

You are right, I read the log files too quickly. Sorry!

Yet I do not see why StackOverflowError only arises on the musl Linux platform. In Julia, this kind of error is usually the sign of an infinite function call recursion. I will investigate that.

@emmt
Copy link
Collaborator Author

emmt commented Oct 20, 2023

I suggest to add a reference to the Julia package NOMAD.jl.

Good idea! Done in a73f854 of this PR.

@zaikunzhang
Copy link
Member

Thank you @emmt and @amontoison . I give some comments at #14 for your consideration. In particular, #14 (comment)

BTW, due to some urgent deadlines, I will be almost away from GitHub until the end of the month. Thank you for your understanding.

@amontoison
Copy link
Member

@emmt Should we remove Linux MUSL from CI?

@emmt
Copy link
Collaborator Author

emmt commented Oct 23, 2023

@amontoison yes we should perhaps do that because Linux musl is not recommended (on Julia download page) for production use. The StackOverflow error my arise from issues not in PRIMA.jl code.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-spelling found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@emmt
Copy link
Collaborator Author

emmt commented Oct 23, 2023

Issue #4 is solved by this PR.

The only remaining issues are the check-spelling ones.

Copy link
Collaborator Author

@emmt emmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issuccess is a false positive, it is the name of this method imported from LinearAlgebra

src/PRIMA.jl Fixed Show fixed Hide fixed
src/PRIMA.jl Fixed Show fixed Hide fixed
@emmt emmt merged commit 46b84ee into libprima:main Oct 23, 2023
14 checks passed
@emmt
Copy link
Collaborator Author

emmt commented Oct 23, 2023

All tests passed. I merge this PR and will trigger a new version (0.2.0) since the API has changed quite substancially...

@emmt emmt deleted the eric-devel branch October 24, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants