-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- gcc 13.3.0 seems to have an issue with math.h on macOS. It spews a bunch of errors about the API_DEPRECATED macro not being used correctly, which is not an issue on our side. gcc 13.2.0 does not seem to have this issue, but since we cannot select gcc with such granularity we downgrade to gcc 12 and hope this fixes the issue for now. - numpy 2.0.0 has come out which causes runtime issues. Fortunately the fix is easy, just build with pybind11 >=2.12.0. However this is still an issue for the pdfo compatibility test since pdfo does not support numpy 2.0.0, and sometimes the tests install 2.0.0 because it happens to be in the pip cache. So we upgrade pybind11 (the new version is compatible with 2.0 and 1.0 numpy) and skip the pdfo test if we happened to pick up numpy 2. - macOS builds for building Python wheels started to complain when running the "delocate" step that libquadmath, libstdc++, and libgfortran have minimum targets of 11.0, whereas the default was 10.9, hence we added the relevant env variable for CIBW. - Notes have been made in build_python.yml for failures related to Ubuntu 24.04.
- Loading branch information
1 parent
be6c3d0
commit 9b8dd73
Showing
4 changed files
with
19 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,11 @@ jobs: | |
fail-fast: false | ||
matrix: | ||
# As of 20240501, macos-11/12/13 are AMD64, and macOS-14 is ARM64. | ||
os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04, windows-2019, windows-2022, macos-11, macos-12, macos-13, macos-14] | ||
# As of 20240616, ubuntu 24.04 is fialing to copy files into the quay.io/pypa/manylinux2014_i686:2024-05-13-0983f6f container | ||
Check failure Code scanning / check-spelling Unrecognized Spelling Error
fialing is not a recognized word. (unrecognized-spelling)
|
||
# It fails with "tar: ./todo: Cannot utime: Function not implemented" for every file in the repo. | ||
# This is strange since it worked for the quay.io/pypa/manylinux2014_x86_64:2024-05-13-0983f6f container. | ||
# I suggest trying ubuntu-24.04 again in a month. | ||
os: [ubuntu-20.04, ubuntu-22.04, windows-2019, windows-2022, macos-11, macos-12, macos-13, macos-14] | ||
|
||
steps: | ||
- name: Clone Repository (Latest) | ||
|
@@ -46,11 +50,19 @@ jobs: | |
- name: Checkout pybind11 submodule | ||
run: git submodule update --init python/pybind11 | ||
|
||
- name: Set the MACOSX_DEPLOYMENT_TARGET | ||
if: ${{ runner.os == 'macOS' }} | ||
run: | | ||
MACOSX_DEPLOYMENT_TARGET=$(swvers --productVersion | cut -d'.' -f 1') | ||
Check failure Code scanning / check-spelling Unrecognized Spelling Error
swvers is not a recognized word. (unrecognized-spelling)
|
||
echo "MACOSX_DEPLOYMENT_TARGET is $MACOSX_DEPLOYMENT_TARGET" | ||
echo "MACOSX_DEPLOYMENT_TARGET=$MACOSX_DEPLOYMENT_TARGET" >> $GITHUB_ENV | ||
- name: Set up Fortran | ||
uses: fortran-lang/setup-fortran@main | ||
if: ${{ runner.os == 'macOS' }} | ||
with: | ||
compiler: gcc | ||
version: 12 | ||
|
||
# Copied from https://github.com/scipy/scipy/blob/main/.github/workflows/wheels.yml | ||
# For rtools, see https://github.com/r-windows/rtools-installer/releases, which has been | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule pybind11
updated
91 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters