feat(parser): add support for value set syntax (X.680-2021 sec 16.6-16.8) #114
Conversation
|
Thank you for your contribution! Would you mind sharing some of your test suite if it's not confidential? |
|
The test suite isn't confidential, but neither is it anything particularly fancy. I just created a new backend that always returns an empty string, and use that to do the same thing that |
6d7a
left a comment
6d7a
left a comment
There was a problem hiding this comment.
Thank you for your contribution and sorry that it took me some time reviewing this. I only have a minor change request.
| if let Some(constraints) = value.3.constraints_mut() { | ||
| constraints.push(Constraint::SubtypeConstraint(value.4)) | ||
| } else { | ||
| eprintln!("{name}: unable to push constraints to {ty:?}", name=value.1, ty=value.3); |
There was a problem hiding this comment.
Could you return an error here instead of logging, so that we report errors consistently through the Result type?
2 participants
This is a first step towards making the X.500 series of ASN.1 specs compile as provided by upstream.
After this change, 2 additional modules from the test suite parse successfully:
However, this does drastically slow down the parser - my test suite that runs the compiler with a null backend runs in 19s instead of 2s. I've not yet figured out why