Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smart-v1: add the ability to run tests on all configured devs via the extend and fix when useSN=1 #479

Merged
merged 2 commits into from
Jul 3, 2023
Merged

smart-v1: add the ability to run tests on all configured devs via the extend and fix when useSN=1 #479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa82f21
add the ability to run tests on all specified devices via -t
VVelox Jun 28, 2023
f0fd4cb
properly save the results when exit is non-zero and useSN=1
VVelox Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 57 additions & 1 deletion snmp/smart-v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ Switches:
-g Guess at the config and print it to STDOUT
-C Enable manual checking for guess and cciss.
-S Set useSN to 0 when using -g
-t <test> Run the specified smart self test on all the devices.
-G <modes> Guess modes to use. This is a comma seperated list.
Default :: scan-open,cciss-vol-status

Expand Down Expand Up @@ -121,9 +122,11 @@ sub main::HELP_MESSAGE {
-Z GZip+Base64 compress the results.
-C Enable manual checking for guess and cciss.
-S Set useSN to 0 when using -g
-t <test> Run the specified smart self test on all the devices.
-G <modes> Guess modes to use. This is a comma seperated list.
Default :: scan-open,cciss-vol-status


Scan Modes:

- scan :: Use "--scan" with smartctl. "scan-open" will take presidence.
Expand All @@ -140,7 +143,7 @@ Scan Modes:

#gets the options
my %opts = ();
getopts( 'ugc:pZhvCSG', \%opts );
getopts( 'ugc:pZhvCSGt:', \%opts );

if ( $opts{h} ) {
&HELP_MESSAGE;
Expand Down Expand Up @@ -472,10 +475,61 @@ while ( defined( $configA[$configA_int] ) ) {
$configA_int++;
} ## end while ( defined( $configA[$configA_int] ) )

#
#
# run the specified self test on all disks if asked
#
#
if ( defined( $opts{t} ) ) {

# make sure we have something that atleast appears sane for the test name
my $valid_tesks = {
'offline' => 1,
'short' => 1,
'long' => 1,
'conveyance' => 1,
'afterselect,on' => 1,
};
if ( !defined( $valid_tesks->{ $opts{t} } ) && $opts{t} !~ /select,(\d+[\-\+]\d+|next|next\+\d+|redo\+\d+)/ ) {
print '"' . $opts{t} . "\" does not appear to be a valid test\n";
exit 1;
}

print "Running the SMART $opts{t} on all devices in the config...\n\n";

foreach my $line (@disks) {
my $disk;
my $name;
if ( $line =~ /\ / ) {
( $name, $disk ) = split( /\ /, $line, 2 );
} else {
$disk = $line;
$name = $line;
}
if ( $disk !~ /\// ) {
$disk = '/dev/' . $disk;
}

print "\n------------------------------------------------------------------\nDoing "
. $smartctl . ' -t '
. $opts{t} . ' '
. $disk
. " ...\n\n";
print `$smartctl -t $opts{t} $disk` . "\n";

} ## end foreach my $line (@disks)

exit 0;
} ## end if ( defined( $opts{t} ) )

#if set to 1, no cache will be written and it will be printed instead
my $noWrite = 0;

#
#
# if no -u, it means we are being called from snmped
#
#
if ( !defined( $opts{u} ) ) {
# if the cache file exists, print it, otherwise assume one is not being used
if ( -f $cache ) {
Expand Down Expand Up @@ -812,6 +866,8 @@ foreach my $line (@disks) {
# only bother to save this if useSN is not being used
if ( !$useSN ) {
$to_return->{data}{disks}{$disk_id} = \%IDs;
} elsif ( $IDs{exit} == 0 ) {
$to_return->{data}{disks}{$disk_id} = \%IDs;
}
} ## end foreach my $line (@disks)

Expand Down