Skip to content

Conversation

@james-d-mitchell
Copy link
Member

Will require

libsemigroups/libsemigroups#847

to be merged before the ci here will pass.

@james-d-mitchell james-d-mitchell added the libsemigroups-feature-not-yet-supported Label for issues and PRs related to features of libsemigroups not yet supported here label Nov 7, 2025
Copy link
Collaborator

@Joseph-Edwards Joseph-Edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I've requested one small doc change, and made one comment, but otherwise I'm happy for this to be merged.

It's worth noting that we expect this to fail the conda libsemigroups jobs. This raises the question that maybe they should only be run when making PRs into stable-*, or on a release? What do you think @james-d-mitchell?

@Joseph-Edwards Joseph-Edwards mentioned this pull request Nov 7, 2025
@james-d-mitchell
Copy link
Member Author

This looks good to me. I've requested one small doc change, and made one comment, but otherwise I'm happy for this to be merged.

It's worth noting that we expect this to fail the conda libsemigroups jobs. This raises the question that maybe they should only be run when making PRs into stable-*, or on a release? What do you think @james-d-mitchell?

I think that'd be a good idea, this way we'll only see proper errors, not out of sync issues like this.

@james-d-mitchell james-d-mitchell merged commit 3d14e86 into libsemigroups:main Nov 9, 2025
15 of 17 checks passed
@james-d-mitchell james-d-mitchell deleted the sync-forest branch November 9, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libsemigroups-feature-not-yet-supported Label for issues and PRs related to features of libsemigroups not yet supported here

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants