Skip to content

Conversation

mikkoi
Copy link

@mikkoi mikkoi commented Oct 4, 2025

Issue #391

@oalders
Copy link
Member

oalders commented Oct 5, 2025

We should probably check with @petdance about being the security contact. Not sure if that conversation happened somewhere else?

@mikkoi
Copy link
Author

mikkoi commented Oct 5, 2025

Another possibility would be to harness GitHub's new Private vulnerability reporting in Security (tab).

@petdance
Copy link
Contributor

petdance commented Oct 5, 2025

Heavens, no, I shouldn't be a contact for anything.

@oalders
Copy link
Member

oalders commented Oct 6, 2025

Another possibility would be to harness GitHub's new Private vulnerability reporting in Security (tab).

Oh, I did not know about this. I've enabled it for this repo. Can we amend the document to reflect this?

@mikkoi
Copy link
Author

mikkoi commented Oct 6, 2025

Oh, I did not know about this. I've enabled it for this repo. Can we amend the document to reflect this?

Will do!

... by GitHub's Report a vulnerability submission form
@mikkoi
Copy link
Author

mikkoi commented Oct 8, 2025

Done.

@mikkoi
Copy link
Author

mikkoi commented Oct 8, 2025

Shall we add a similar SECURITY.md to LWP::UserAgent?

@oalders
Copy link
Member

oalders commented Oct 8, 2025

Shall we add a similar SECURITY.md to LWP::UserAgent?

Please

Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some proposed changes in #398. Could you review those? I don't know why it didn't just comment on this PR. Maybe I don't know how to invoke copilot correctly.

@mikkoi
Copy link
Author

mikkoi commented Oct 8, 2025

I would say Copilot did a good job. It noticed spelling errors and the wrong branch name.
I applied the fixes over the original.

@oalders
Copy link
Member

oalders commented Oct 9, 2025

It looks like I should have requested a review from copilot under the "Reviewers" section.

Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mikkoi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants