Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes mono detection so mono is used on vt220 as originally intended #51

Closed
wants to merge 3 commits into from

Conversation

hramrach
Copy link

@hramrach hramrach commented Oct 17, 2016

There is a separate question why xterm and screen have different color theme from rxvt or why vt220 is supposed to be mono.

However, it the theme selection code says vt220 is supposed to be mono make it mono.

This results from investigation of (bsc#1002985).

This does not resolve the problem completely but fixes initialization problem which causes incorrect theme assignment.

@mvidner
Copy link
Member

mvidner commented Oct 20, 2016

(This is a fix for #49)

Thanks! I have tried this out and it does fix the original problem of navigating the main YaST menu.

But I have noticed that I still cannot see the bold letters that mark the shortcut keys for the buttons. Is it a problem for you too?

@hramrach
Copy link
Author

Yes, I recall something like that.

Basically there are 3 themes that I managed to trigger. The b&w one which is made available with this and is good fallback when the terminal is not known to support colors, the full-color one with blue background which triggers on well-known terminals like linux and screen. The one with black background seems to be some low-color fallback.

In the b&w theme buttons are full bold so the shortcut letters are not visible. Alternatives like underline exist but this has to be fixed in the theme itself.

In the meantime somebody fixed the low-color theme to show the selection inverted so that theme works reasonably well now.

As to the assignment of different themes to different terminals I am somewhat at a loss as to why vt220, rxvt, and xterm get different theme when being basically the same terminal wrt color capability.

@shundhammer shundhammer closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants