Implement api/tournament endpoints
#50
Conversation
|
Hey, thanks for the PR, since |
There was a problem hiding this comment.
Thanks for fixing the typos!
Re: return type annotations, ideally, we'd like to have accurate return types using TypedDicts for new endpoints. See #38 for an example. Although I believe for tournaments, the return types are in some cases very complex and not 100% correct on the wiki, in which case it might be ok to leave them out. But best to check and we'd at least still want something like Dict[str, Any].
Also, for endpoints like withdraw that only return "ok", it's better to not return anything (but they should still get a -> None annotation). The result in this case will always be "ok" since it will throw if it errors, so returning something gives the incorrect impression that the return value has real meaning and should be checked and can also obscure the fact that errors will throw.
Anupya
force-pushed
the
Anupya/add-tournament-endpoints
branch
3 times, most recently
from
caffb3b
to
efef654
Compare
berserk/clients/tournaments.py
Outdated
| } | ||
| self._r.post(path=path, params=params, converter=models.Tournament.convert) | ||
|
|
||
| def get_team_standings(self, tournament_id: str) -> Dict[str, Any]: |
There was a problem hiding this comment.
the response is simple enough to be typed: https://lichess.org/api#tag/Arena-tournaments/operation/resultsByTournament please also include a test for it
Anupya
force-pushed
the
Anupya/add-tournament-endpoints
branch
from
efef654
to
986effa
Compare
|
Update - I am having trouble making that test pass due to my Python version being wrong and my local being weird. I'm gonna be busy at work again so may not have time to get to it. Please fix it if you can 🙏 but the other stuff should work. |
kraktus
force-pushed
the
Anupya/add-tournament-endpoints
branch
from
d5cf59c
to
5dcba7c
Compare
|
Thanks again for the numerous PRs! Quite a significant leap in coverage |
Description
get_team_standings=/api/tournament/{id}/teams(there is no/api/swissequivalent)update_team_battle=/api/tournament/team-battle/{id}(there is no/api/swissequivalent)join_arena=/api/tournament/{id}/jointerminate_arena=/api/tournament/{id}/terminatewithdraw_arena=/api/tournament/{id}/withdrawget_tournamentparamsiduppercaseAfter merge
Please update #6 and check off all the five
api/tournament/...endpoints in the issue description.Also there are several endpoints in the issue description that have already been implemented but not been checked off. I think there's only 6-7 endpoints left in that list and everything else can be checked off.