Crazyhouse en passant bug with DropMove #24
Conversation
| a = a.playSan('Bd8'); | ||
|
|
||
| a = a.playSan('Nc3'); | ||
| printBoard(a, printLegalMoves: true); |
|
|
||
| a = a.playSan( | ||
| 'Q@f7'); // Bug: copyWith() is given null for epSquare, which then copies White's epSquare of f6 forward to Black | ||
| final List<Move> legalMoves = printBoard(a, printLegalMoves: true); |
There was a problem hiding this comment.
it's a bit weird to define legalMoves using a printBoard function; I think you can just use a list literal instead.
There was a problem hiding this comment.
I'm concerned with this whole file. While I understand how it can help you to understand better a situation and see the legal moves for a position I think it should stay private code.
If that code was meant to be in the repo I'd name things differently (MyExpectations is a bit vague) and put doc comments.
You're comparing the number of legal moves in a position. In a way it's like perft, so I think this whole test should be replaced by a perft test.
Perft has the advantage of being a standard and I prefer dartchess to use such standards. Another great advantage is that you can run perft tests on other chess libraries to ensure even more the validity.
Fixes #23