Fix incorrect PGN parsing of move number tokens like "11... c5??" (WIP) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcitem
force-pushed
the
patch-1
branch
4 times, most recently
from
3e90a51 to
1c1fa0d
Compare
This commit adds a small patch to detect tokens that represent a move number, such as "11." or "11...", and store them temporarily. The next real move token (e.g. "c5??") is then combined with the pending move number to form "11...c5??", ensuring the move is not treated as a separate root-level node. This prevents parsing errors in PGN trees where moves like "11... c5??" were incorrectly inserted alongside sibling moves, instead of as a child in the correct place.
|
Draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a small patch to detect tokens that represent a move number,
such as "11." or "11...", and store them temporarily. The next real move token
(e.g. "c5??") is then combined with the pending move number to form "11...c5??",
ensuring the move is not treated as a separate root-level node. This prevents
parsing errors in PGN trees where moves like "11... c5??" were incorrectly
inserted alongside sibling moves, instead of as a child in the correct place.
(TODO: Test)