feat: support toggling dragged piece shadows #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloce
reviewed
Oct 7, 2024
| @@ -94,6 +95,9 @@ class ChessboardSettings { | |||
| // Offset for the piece currently under drag | |||
| final Offset dragFeedbackOffset; | |||
|
|
|||
| /// Whether the dark shadow under dragged pieces is enabled | |||
There was a problem hiding this comment.
Dark shadow sounds a bit ominous. What about "the shadow circle"?
| @@ -94,6 +95,9 @@ class ChessboardSettings { | |||
| // Offset for the piece currently under drag | |||
| final Offset dragFeedbackOffset; | |||
|
|
|||
| /// Whether the dark shadow under dragged pieces is enabled | |||
| final bool pieceShadow; | |||
There was a problem hiding this comment.
pieceShadow can be confused with regular shadows of the pieces; so it should be renamed: draggedPieceShadow for instance.
| @@ -247,6 +256,9 @@ class ChessboardEditorSettings { | |||
| // Offset for the piece currently under drag. | |||
| final Offset dragFeedbackOffset; | |||
|
|
|||
| // Whether the dark shadow under dragged pieces is enabled. | |||
There was a problem hiding this comment.
Same comment as above. Also it should be a triple slash (not double).
| @@ -169,21 +170,21 @@ class _BoardState extends State<Chessboard> { | |||
| Widget build(BuildContext context) { | |||
| final colorScheme = widget.settings.colorScheme; | |||
| final ISet<Square> moveDests = widget.settings.showValidMoves && | |||
| selected != null && | |||
There was a problem hiding this comment.
Why these indentation changes? Please format your code with dart format.
|
Superseded with #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to implement toggling the shadows underneath dragged pieces as proposed in lichess-org/mobile#977