-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more setup from Bash to Rust #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes and working perfectly! I'd recommend using if command -v rustup &> /dev/null
instead of which
though. Not only will it remove the extra output that's generated when rustup
is missing, but it's also safer. Here's a good write up on it: https://stackoverflow.com/a/677212/4433744
Bash script will now compile the binary and then the host will run the binary directly, instead of running
cargo run
via Docker like it did before.The Rust code is now responsible for creating the repo dirs and cloning.
Goal is to cleanup the bash script and try to limit it to being just a wrapper around various
docker
commands.This branch on gitpod: https://gitpod.io/#https://github.com/lichess-org/lila-docker/tree/rust