Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more setup from Bash to Rust #31

Merged
merged 15 commits into from
Nov 24, 2023
Merged

Move more setup from Bash to Rust #31

merged 15 commits into from
Nov 24, 2023

Conversation

fitztrev
Copy link
Member

@fitztrev fitztrev commented Nov 23, 2023

Bash script will now compile the binary and then the host will run the binary directly, instead of running cargo run via Docker like it did before.

The Rust code is now responsible for creating the repo dirs and cloning.

Goal is to cleanup the bash script and try to limit it to being just a wrapper around various docker commands.

This branch on gitpod: https://gitpod.io/#https://github.com/lichess-org/lila-docker/tree/rust

Copy link
Member

@trevorbayless trevorbayless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes and working perfectly! I'd recommend using if command -v rustup &> /dev/null instead of which though. Not only will it remove the extra output that's generated when rustup is missing, but it's also safer. Here's a good write up on it: https://stackoverflow.com/a/677212/4433744

@fitztrev fitztrev merged commit 20bf71c into main Nov 24, 2023
4 checks passed
@fitztrev fitztrev deleted the rust branch November 24, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants