fix: set empty BABASHKA_CLASSPATH #15
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
or maybe put something like |
Author
|
I raised this upstream, maybe we can have a better solution upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fix is to ensure the uberscript brepl installed not be affected by the bb.edn file in local folder when running the brepl inside that folder.
For example, in folder ~/user/project, if that folder happens to contain a bb.edn with deps (not relevant to brepl), running brepl would still download that deps from bb.edn, which is not correct.
I only fixed the nix version in this pr. You may need to advice/fix the wrap approach either with the BABASHKA_CLASSPATH empty approach or
bb --config nil ubserscriptfor other platforms.NixOS/nixpkgs#454426