Fix alignement issue identified by @AvenGeeker

Resolve #993
lief-project · Nov 7, 2023 · 6b73798 · 6b73798
1 parent 6a98c63
commit 6b73798
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/MachO/Builder.tcc b/src/MachO/Builder.tcc
@@ -648,7 +648,7 @@ ok_error_t Builder::build(SymbolCommand& symbol_command) {
         ++isym;
       }
     }
-    nlist_table.align(8);
+    nlist_table.align(binary_->is64_ ? 8 : 4);
 
     raw_nlist_table = nlist_table.raw();
     symtab.symoff = linkedit_offset_ + linkedit_.size();

diff --git a/tests/macho/test_issues.py b/tests/macho/test_issues.py
@@ -1,6 +1,7 @@
 #!/usr/bin/env python
 import lief
 from utils import get_sample
+from pathlib import Path
 
 def test_945():
     target = lief.MachO.parse(get_sample("MachO/python3_issue_476.bin")).at(0)
@@ -12,3 +13,12 @@ def test_945():
     for load_command in target.commands:
         if load_command.command in (lief.MachO.LOAD_COMMAND_TYPES.SEGMENT, lief.MachO.LOAD_COMMAND_TYPES.SEGMENT_64):
             assert isinstance(load_command, lief.MachO.SegmentCommand)
+
+def test_993(tmp_path):
+    target = lief.MachO.parse(get_sample("MachO/alivcffmpeg_armv7.dylib"))
+    out = Path(tmp_path) / "issue_993.dylib"
+    target.write(out.as_posix())
+
+    new = lief.MachO.parse(out)
+    not_err, msg = lief.MachO.check_layout(new)
+    assert not_err, msg