Resolve #1034

lief-project · Mar 17, 2024 · 6dbb551 · 6dbb551
1 parent ec17282
commit 6dbb551
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/api/python/lief/PE.pyi b/api/python/lief/PE.pyi
@@ -701,7 +701,7 @@ class CodeView(Debug):
 
 class CodeViewPDB(CodeView):
     age: int
-    filename: str
+    filename: Union[str,bytes]
     signature: list[int]
     def __init__(self) -> None: ...
     @property

diff --git a/api/python/src/PE/objects/debug/pyCodeViewPDB.cpp b/api/python/src/PE/objects/debug/pyCodeViewPDB.cpp
@@ -22,6 +22,8 @@
 #include <nanobind/stl/string.h>
 #include <nanobind/stl/array.h>
 
+#include "pySafeString.hpp"
+
 namespace LIEF::PE::py {
 
 template<>
@@ -55,7 +57,9 @@ void create<CodeViewPDB>(nb::module_& m) {
         nb::overload_cast<uint32_t>(&CodeViewPDB::age))
 
     .def_prop_rw("filename",
-        nb::overload_cast<>(&CodeViewPDB::filename, nb::const_),
+        [] (const CodeViewPDB& self) {
+          return LIEF::py::safe_string(self.filename());
+        },
         nb::overload_cast<std::string>(&CodeViewPDB::filename),
         "Original pdb path")