Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustls-tls feature to reqwest #1105

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Huntragon
Copy link
Contributor

The rust bindings use reqwest to download prebuilt binaries and link against those. This is done via an HTTPS request, and TLS is provided by using openssl. When building via nix, this is an issue since it requires having openssl present so it can link against it.
By adding the rusttls-tls feature to reqwest, it uses a pure rust implementation of TLS, simplifying the building process.

@Huntragon Huntragon force-pushed the reqwest-use-rust-tls branch 2 times, most recently from 510dfe2 to 83ce150 Compare September 16, 2024 11:09
@romainthomas
Copy link
Member

Thanks @Huntragon

It makes sense to avoid requiring openssl if there is a pure Rust TLS implementation.

Thank you for this improvement

@romainthomas romainthomas merged commit 2b5a5eb into lief-project:main Sep 19, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants