Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Product2 for 0 and 1 inputs #32

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix Product2 for 0 and 1 inputs #32

merged 1 commit into from
Nov 17, 2023

Conversation

orsinium
Copy link
Member

@orsinium orsinium commented Nov 17, 2023 •
edited
Loading

Fix 2 bugs:

  1. Product2 panics for zero arguments
  2. Product2 never closes the channel for one argument.

@orsinium orsinium merged commit 83c9345 into master Nov 17, 2023
7 checks passed
@orsinium orsinium deleted the fix-product2 branch November 17, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@orsinium