Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added lambdaRegion option to config options #175

Conversation

alice-byb
Copy link
Contributor

This will let the consumer decide which region to invoke on the target function.

If trying network request across regions, the user must currently pass the entire Lambda class in just to configure this one variable

@alice-byb alice-byb changed the title feature: added lambdaRegion option to config options feat: added lambdaRegion option to config options Aug 16, 2024
@alice-byb alice-byb force-pushed the feature/add-lambdaRegion-option-to-alpha-config branch from a6259fe to 9921578 Compare August 16, 2024 07:16
@mdlavin
Copy link
Member

mdlavin commented Aug 16, 2024

The change looks good to me. Thanks for the addition and assuming it passes, I'll merge it

@mdlavin mdlavin self-assigned this Aug 16, 2024
@mdlavin mdlavin self-requested a review August 16, 2024 12:58
@mdlavin
Copy link
Member

mdlavin commented Aug 16, 2024

Would you mind signing your commit so it can be merged?

Screenshot 2024-08-16 at 8 59 13 AM

@alice-byb alice-byb force-pushed the feature/add-lambdaRegion-option-to-alpha-config branch from 9921578 to 4618753 Compare August 18, 2024 23:53
this will let the consumer decide which region to invoke on the target function
if trying to make a network request across regions, the user must previously pass the entire Lambda class in just to configure this one variable
@alice-byb alice-byb force-pushed the feature/add-lambdaRegion-option-to-alpha-config branch from 4618753 to 7e6bcf6 Compare August 18, 2024 23:54
@alice-byb
Copy link
Contributor Author

Would you mind signing your commit so it can be merged?

Screenshot 2024-08-16 at 8 59 13 AM

Thanks for reviewing, I've force pushed a signed commit now 👍🏻

@alice-byb alice-byb requested a review from mdlavin August 21, 2024 03:45
@mdlavin mdlavin merged commit d58fda4 into lifeomic:master Aug 21, 2024
6 checks passed
@mdlavin
Copy link
Member

mdlavin commented Aug 21, 2024

I just merged this, so a new version should be released automatically. Thanks for the change along with a testcase.

Copy link

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants