LPD-62912 Add support for SQL Server #119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-chu
commented
Sep 30, 2025
drewbrokke
requested changes
Oct 1, 2025
| from configurations.sqlserver | ||
| into "configs/common/tomcat/webapps/ROOT/WEB-INF/shielded-container-lib" | ||
| } | ||
|
|
There was a problem hiding this comment.
Parameterize the existing driver task to accept a configuration
|
|
||
| main & /opt/mssql/bin/sqlservr | ||
|
|
||
| wait No newline at end of file |
There was a problem hiding this comment.
Take one more look at the SQLServer image to make sure that we can't use something they already provide for us.
There was a problem hiding this comment.
According to Microsoft's documentation, we can only use the UI (which we don't have in this case) or the SQL statements (which we have via SQL files).
|
@anthony-chu looks like a real failure during the SF check. |
|
See #120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-62912