LPD-69550 Include glowroot/data folder as part of exported data #157
Conversation
anthony-chu
force-pushed
the
LPD-69550
branch
3 times, most recently
from
192fcbb to
83cf7d5
Compare
drewbrokke
left a comment
drewbrokke
left a comment
There was a problem hiding this comment.
@anthony-chu how does this behave if Glowroot is not enabled? Any side-effects?
|
@anthony-chu sorry just merged Anna's PR, there's a merge conflict now. |
anthony-chu
force-pushed
the
LPD-69550
branch
from
83cf7d5 to
3ca1e72
Compare
|
This will probably need to wait for the new volume export/import changes to go in first, since this PR modifies the (soon-to-be) mostly defunct |
|
|
||
| COPY --chown=1000:1000 ${DATA_DIRECTORY} /container-data | ||
|
|
||
| RUN mkdir -p /container-data/glowroot && chown -R 1000:1000 /container-data/glowroot |
There was a problem hiding this comment.
Why is this line needed for glowroot but not any other services? Why wouldn't you need to do this for the liferay service as well?
There was a problem hiding this comment.
the liferay volume didn't need this because it points to a directory that already exists in the liferay/dxp image (/opt/liferay/data); docker copies the existing content into the volume. on the other hand, the glowroot volume points to a directory that doesn't exist in the volume (/opt/liferay/glowroot/data, the important part being the .../data directory); since the data directory doesn't already exist in /opt/liferay/glowroot directory (which does exist), then docker creates it, and it gets created with root permissions.
i checked with Jordi, and he mentioned that they did not need anything else from the /opt/liferay/glowroot directory besides the data folder; however, we would need to do the above if the glowroot volume were tied only to the /opt/liferay/glowroot/data directory. if, instead, it pointed to the /opt/liferay/glowroot directory more broadly, then we wouldn't need to chown.
if that's sufficient enough of a workaround for our case (i've already tested that it works), then i can switch the glowroot volume just to point to /opt/liferay/glowroot and get rid of the chown.
|
@anthony-chu I think you can start re-working this one on top of #165. |
2 participants
https://liferay.atlassian.net/browse/LPD-69550