LPD-64121 check if the group has workflow links if needed

[robertoDiaz]

What is this trying to solve?

https://liferay.atlassian.net/browse/LPD-64121

Use the default web content workflow configuration

How am I fixing it?

If the folder doesn't have a configured workflow config get it from the group

How to test it?

Since create a functional test could be too complex and this is not a very problematic issue, this could be tested following the steps of the LPD ticket.

[gemini-code-assist]

Summary of Changes

Hello @robertoDiaz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request ensures that web content workflow configurations are consistently applied by introducing a mechanism to default to the group's general web content workflow settings when a specific folder lacks a direct configuration. This enhances the robustness of workflow management for journal folders, aligning with the default web content workflow configuration strategy.

Highlights

• Workflow Configuration Fallback: Implemented a fallback mechanism in edit_folder.jsp to retrieve a default workflow configuration from the group level for JournalArticle if a specific JournalFolder does not have one configured.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements a fallback to the group's default workflow configuration when a specific workflow is not set for a journal folder. The logic is sound. I've added one suggestion to improve code readability and maintainability by replacing a magic number with an existing constant, which will make the code more consistent.

[gemini-code-assist]

For consistency and improved readability, please replace the magic number 0 for the ddmStructureId parameter (the fifth argument) with the constant JournalArticleConstants.DDM_STRUCTURE_ID_ALL. This aligns with the similar service call on line 332 and makes the code's intent clearer.

								workflowDefinitionLink = WorkflowDefinitionLinkLocalServiceUtil.fetchWorkflowDefinitionLink(company.getCompanyId(), scopeGroupId, JournalArticle.class.getName(), 0, JournalArticleConstants.DDM_STRUCTURE_ID_ALL, true);