feat: add playwright tests to examples #615
Open
+312
−447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effie-ms
commented
Dec 2, 2025
|
|
||
| export default defineConfig({ | ||
| testDir: './tests', | ||
| fullyParallel: false, |
Contributor
Author
There was a problem hiding this comment.
To discuss: parallelism - pnpm level or within Playwright
effie-ms
commented
Dec 2, 2025
| /** | ||
| * See https://playwright.dev/docs/test-configuration. | ||
| */ | ||
| const port = 4173 |
Contributor
Author
There was a problem hiding this comment.
Ports should be different for each example if we run tests in parallel (pnpm level)
effie-ms
commented
Dec 2, 2025
| }, | ||
| ], | ||
| webServer: { | ||
| command: `NPM_CONFIG_LOGLEVEL=error npm run dev -- --port ${port}`, |
Contributor
Author
There was a problem hiding this comment.
(pnpm just hangs on some reason, used npm)
Contributor
Author
|
@chybisov can you check this setup, what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira task is linked to this PR?
https://lifi.atlassian.net/browse/LF-16706
Why was it implemented this way?
This PR:
connectkitandvitedata-testidto widgetdata-testidare released.Checklist before requesting a review