Skip to content

Commit

Permalink
ruby: Upgrade to v3.1.4 (pt. 1, base image only) (forem#19871)
Browse files Browse the repository at this point in the history
In forem#19776 we discovered that basing both the base container *and* the
app container off of `.ruby-version` causes a chicken-and-egg problem
wherein upgrading Ruby versions requires a few stop-and-gos. Let's make
those stops reviewable as separate chunks instead: use a new
`.ruby-version-next` for building base images, not the `.ruby-version`,
thus allowing GitHub Actions to fire off an automated build (which, when
complete, we can take the SHA sum from and use it to open a second PR
updating the app image to use it, and `.ruby-version` can be updated to
match `.ruby-version-next`).
  • Loading branch information
klardotsh authored Aug 2, 2023
1 parent fd7e28b commit f0346d8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .ruby-version-next
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.1.4
2 changes: 1 addition & 1 deletion scripts/build_base_ruby_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if [ "$(pwd)" != "$(git rev-parse --show-toplevel)" ]; then
fi

BUILD_PLATFORMS="${BUILD_PLATFORMS:-linux/amd64,linux/arm64}"
RUBY_VERSION="${RUBY_VERSION:-$(cat .ruby-version)}"
RUBY_VERSION="${RUBY_VERSION:-$(cat .ruby-version-next)}"
IMAGE="ghcr.io/forem/ruby:${RUBY_VERSION}"

if [ -z "${SKIP_PUSH:-}" ]; then
Expand Down

0 comments on commit f0346d8

Please sign in to comment.