Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala3-library to 3.3.4 #831

Merged

Conversation

scala-steward
Copy link
Contributor

@scala-steward scala-steward commented Sep 28, 2024

About this PR

πŸ“¦ Updates org.scala-lang:scala3-library from 3.3.3 to 3.3.4

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-library" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala3-library" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:semver-spec, commit-count:1

SethTisue
SethTisue previously approved these changes Oct 3, 2024
@SethTisue SethTisue self-assigned this Oct 3, 2024
@SethTisue
Copy link
Collaborator

SethTisue commented Oct 10, 2024

The following problem(s) were reported but not expected (1):
+method boxedStringy()scala.Option in class Bar has a different generic signature in new version, where it is ()Lscala/Option<LFoo;>; rather than ()Lscala/Option<Ljava/lang/String;>;. See https://github.com/lightbend-labs/mima#incompatiblesignatureproblem
- βœ—  3 / value-class-generic-replacement-nok: com.typesafe.tools.mima.lib.CollectProblemsTest$$anon$1: CollectProblemsTest failure

possible next steps:

  • study the test case to see whether I think the new answer is right or wrong (what does Scala 2 say?)
  • try to figure out which 3.3.4 change could be causing this

@SethTisue
Copy link
Collaborator

SethTisue commented Oct 23, 2024

presumably it's scala/scala3#20463 ? which brings Scala 3 in alignment with Scala 2, so we could just remove the Scala 3 specific expected result

@SethTisue SethTisue merged commit 4f8d292 into lightbend-labs:main Oct 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants