Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Avoid loading all the environment variables as configurations #686

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Fix: Avoid loading all the environment variables as configurations #686

merged 1 commit into from
Jun 24, 2020

Conversation

andreaTP
Copy link
Contributor

@andreaTP andreaTP commented May 7, 2020

mkurz
mkurz approved these changes May 11, 2020
View reviewed changes
Copy link

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkurz
Copy link

mkurz commented May 11, 2020

@havocp Can you have a look? Basically this fixes the original pull request #620

@mkurz mkurz mentioned this pull request May 11, 2020
Closed
@havocp havocp merged commit e0984d4 into lightbend:master Jun 24, 2020
@mkurz mkurz mentioned this pull request Sep 18, 2020
Closed
perovovao
perovovao reviewed Dec 15, 2021
View reviewed changes
Copy link

@perovovao perovovao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovemymaryn

@ekrich ekrich mentioned this pull request Jun 16, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perovovao perovovao perovovao left review comments

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreaTP @mkurz @perovovao @havocp