Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dictionary filter statistics that are based on
java.util.HashSet
. Now user can choose betweenbloom
(Bloom filter statistics) anddict
(Dictionary filter statistics) when creating index.Also added/updated filter statistics tests and read correctness tests.
Benchmarks on test dataset of 1,000,000 records with simple
Or(EqualTo(code,2),EqualTo(code,120))
query shows that with bloom filter statistics Spark would scan ~8 files. Same dataset with same filter and dictionary filter statistics would read only 2 files (both codes are in different files).Dictionary filters are slower (x2) to create than bloom filters, and they take more space, stats below for sample dataset: