Skip to content

update your code #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update your code #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be9f40b
Create README.md
samglish Jun 6, 2025
f59eff8
Update cities.html
samglish Jun 6, 2025
8df01f5
Update README.md
samglish Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Git collaboration, @Mania

## 🌐 Web Standards and Accessibility

| Before | After |
|--------------------------------|------------------------------------------------------------------------|
| No `lang` attribute | Added `lang="fr"` to specify the content language (French) |
| No character encoding | Added `<meta charset="UTF-8">` to properly display special characters |
| Not mobile-friendly | Added `<meta name="viewport">` for responsive design |

---

## Visual Presentation (CSS Styling)

| Before | After |
|----------------------------|-----------------------------------------------------------------------|
| Only `font-size` defined | Added modern font, background color, text color, padding, and spacing |
| Plain list | Bold city names and proper spacing between items |
| Unstyled links | Colored links with hover effect |

---

## Content Quality

| Before | After |
|-------------------------|-------------------------------------------------------------------------|
| Only 4 cities listed | Extended to 8 major cities |
| Hard-to-read numbers | Formatted numbers using non-breaking spaces (e.g. `17 836 133`) |
| Content in English | Translated fully into **French** to match `lang="fr"` |

---

## External Link Best Practices

| Before | After |
|-----------------------------------|------------------------------------------------------------------------|
| Just a basic link | Added `target="_blank"` to open in a new tab |
| — | Added `rel="noopener noreferrer"` for security and performance |

---

## Professional HTML Structure

- Clean indentation
- Proper semantic tags: `<h1>`, `<ol>`, `<li>`, `<strong>`
- Organized internal CSS
- Full, valid HTML5 structure

---
63 changes: 51 additions & 12 deletions cities.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,70 @@
<!DOCTYPE html>
<html>
<html lang="fr">
<head>
<title>Git Collab Exercise</title>
<style type="text/css">
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Villes les plus peuplées</title>
<style>
body {
font-size: 2.0em;
font-family: Arial, sans-serif;
font-size: 1.2em;
background-color: #f5f7fa;
color: #2c3e50;
margin: 0;
padding: 2em;
line-height: 1.6;
}

h1 {
color: #1a237e;
}

p a {
color: #1565c0;
text-decoration: none;
}

p a:hover {
text-decoration: underline;
}

hr {
border: none;
border-top: 2px solid #cfd8dc;
margin: 1.5em 0;
}

ol {
padding-left: 1.5em;
}

li {
margin: 0.5em 0;
}
</style>
</head>
<body>

<h1>Top cities, by population</h1>
<h1>Les villes les plus peuplées au monde</h1>

<p>
Taken (borrowed?) from
<a href="http://en.wikipedia.org/wiki/List_of_cities_proper_by_population" target="_blank">
Wikipedia
Données extraites de&nbsp;
<a href="https://fr.wikipedia.org/wiki/Liste_des_villes_les_plus_peupl%C3%A9es_du_monde" target="_blank" rel="noopener noreferrer">
Wikipédia
</a>
</p>

<hr/>

<ol>
<li>Shanghai (17,836,133)</li>
<li>Istanbul (13,854,740)</li>
<li>Karachi (12,991,000)</li>
<li>Mumbai (12,478,447)</li>
<li><strong>Shanghai</strong> – 17 836 133 habitants</li>
<li><strong>Istanbul</strong> – 13 854 740 habitants</li>
<li><strong>Karachi</strong> – 12 991 000 habitants</li>
<li><strong>Mumbai</strong> – 12 478 447 habitants</li>
<li><strong>São Paulo</strong> – 12 252 023 habitants</li>
<li><strong>Pékin</strong> – 11 716 620 habitants</li>
<li><strong>Delhi</strong> – 11 007 835 habitants</li>
<li><strong>Lagos</strong> – 10 578 000 habitants</li>
</ol>

</body>
Expand Down