Group python interface prototype #398
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasWurst
reviewed
Jan 14, 2026
Comment on lines
+40
to
+41
| "img": ImageCreateFromPath(path=str(image_path)), | ||
| "vid": VideoCreateFromPath(path=str(video_path)), |
Contributor
There was a problem hiding this comment.
I feel this naming is overly specific. Do we see cases different FromPath?
I think i would love to see simply Image() and Video()
Comment on lines
+22
to
+29
| group_ds = GroupDataset.create( | ||
| components=[ | ||
| ("img", SampleType.IMAGE), | ||
| ("vid", SampleType.VIDEO), | ||
| ("extra", SampleType.IMAGE), | ||
| ], | ||
| name="test_group_dataset", | ||
| ) |
Contributor
There was a problem hiding this comment.
I think this is really nice. It introduces the wording components to the user. It kind of implies that the schema is rigid.
Comment on lines
+48
to
+51
| group_sample = samples[0] | ||
| img_sample = group_sample["img"] | ||
| vid_sample = group_sample["vid"] | ||
| extra_sample = group_sample["extra"] |
Contributor
There was a problem hiding this comment.
This is now very close to dataframe libraries, makes it easy to understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why?
(Delete this: Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.)
How has it been tested?
(Delete this: Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.)
Did you update CHANGELOG.md?