[sql-3] accounts: replace calls to UpdateAccount #939
Conversation
ellemouton
added
no-changelog
ellemouton
force-pushed
the
sql3Accounts3
branch
from
daa5c0b to
e557374
Compare
There was a problem hiding this comment.
Generally looks good! I've left a few comments below, where there's mainly one that needs to be fixed.
As also communicated offline, I do think the added options to the API UpsertAccountPayment makes this updated version harder to read and reason about than the current implementation. I think it's worth considering if it could be designed a bit differently as I feel there's a high risk of introducing bugs when the API is a bit complicated.
ellemouton
force-pushed
the
sql3Accounts3
branch
from
e557374 to
1a69a8b
Compare
There was a problem hiding this comment.
I do think the added options to the API UpsertAccountPayment makes this updated version
Agreed. I do, however, want to keep this series of PRs focused on just switching out the backends without changing the existing behaviour. If we want to make behaviour better, i think it should be done separately (ideas/PRs welcome!) to keep us from scope creeping on this project.
There was a problem hiding this comment.
LGMT after this fix #939 (comment) 🚀!
Just as a small note, since the latest push contained both merge changes + fixes for the PR, I think that would have been a great scenario to either push PR changes separately from merge changes, or include the changes as fixups :).
| // There is a case where the passed in fullAmt is zero but the pending | ||
| // amount is not. In that case, we should not overwrite the pending | ||
| // amount. |
There was a problem hiding this comment.
I don't recall when this can happen. If anyone of you knows, could we update that comment to explain it?
There was a problem hiding this comment.
i think viktor added this comment, so will leave this as a follow up for him
There was a problem hiding this comment.
@ViktorTigerstrom, do you recall how when that can happen?
ellemouton
force-pushed
the
sql3Accounts3
branch
2 times, most recently
from
95dd10e to
f2459eb
Compare
|
oops - fixing race now |
And use it in the InterceptorService's paymentUpdate method.
Instead of useing UpdateAccount.
And use it instead of UpdateAccount.
ellemouton
force-pushed
the
sql3Accounts3
branch
from
2786d53 to
a974e7a
Compare
Instead of UpdateAccount.
In this commit, we avoid race conditions that can happen for tests that directly access the service's `pendingPayment` map.
ellemouton
force-pushed
the
sql3Accounts3
branch
from
a974e7a to
a4506c9
Compare
(similar PR description to #938 but they are not dependent on each other)
To prepare the
accounts.Storeto be more SQL compatible, we will want to replace the currentUpdateAccountmethod. Today it takes a fullOffChainAccountstruct, serialises it and replacesany existing in the DB. This method is not very SQL appropriate as the better pattern is to instead
have specific update methods that read: "Update field X and account with ID Y".
So this PR starts this process of adding more SQL friendly methods to the interface and thereby
phasing out the use of
UpdateAccount. By doing so, we also move very kvdb specific logic outof the
accounts.InterceptorService.I'm splitting this up over about 3 or 4 PRs since some of the replacements are more complicated than
others.
This PR focuses on the calls that edit/add account payments:
UpsertAccountPaymentDeleteAccountPayment