authmailbox: add fallback server support and non-blocking subscriptions #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic unit test coverage for parser function ParseCourierAddress.
Extract fallback authmailbox URLs from the server configuration and pass them to the custodian component. This enables the custodian to handle fallback scenarios using server-provided values.
Introduce MultiSubscriptionConfig to prepare for future extensions with additional config fields.
Add support for passing fallback authmailbox service URLs into MultiSubscriptionConfig. This prepares the config structure to handle server-defined fallback behavior across multiple subscriptions.
Extract mutex-based client management into a new clientRegistry struct to ensure thread-safe access and modifications to the client subscriptions.
Update MultiSubscription.Subscribe to also initiate subscriptions to fallback servers. These connections are established synchronously in a fire-and-forget non-blocking background routine.
ffranr
force-pushed
the
wip/fallback-authmailbox-urls
branch
from
a90114e to
571a891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the robustness of the authmailbox system by introducing support for fallback service URLs and enhancing subscription handling.
The primary goal is to enable redundancy in subscription connections, allowing clients to connect to multiple authmailbox servers in parallel. This reduces the risk of failures caused by a single unresponsive server, addressing reliability issues such as issue #1850.
Core improvements include:
TODO: