Skip to content

Increase default recovery window to 31000 #10630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BlueeeMoon wants to merge 1 commit into from
Closed

Increase default recovery window to 31000 #10630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/commands/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import (

// TODO(roasbeef): expose all fee conf targets

const defaultRecoveryWindow int32 = 2500
const defaultRecoveryWindow int32 = 31000
Copy link

@gemini-code-assist gemini-code-assist bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and provide context for this change, it would be helpful to add a comment explaining why defaultRecoveryWindow is being increased to this specific value. This will help future developers understand the reasoning behind this choice, in line with the style guide's recommendation to explain the 'why' behind code changes.

For example:

// defaultRecoveryWindow is the default number of addresses to scan ahead for
// when recovering a wallet. This value was increased from 2500 to 31000 based
// on user reports of incomplete recovery with the lower value.
const defaultRecoveryWindow int32 = 31000
References
  1. The style guide states that comments should explain the 'why' behind a certain block of code, especially if it requires contextual knowledge not immediately obvious from the code itself. Adding a comment here would clarify the motivation for this specific value. (link)


const (
defaultUtxoMinConf = 1
Expand Down
Loading