Increase recovery window from 2500 to 31000

[BlueeeMoon]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the recovery_window value in the remote signing documentation. The change reflects an increased recovery window for watch-only wallets, ensuring that the provided example code aligns with potentially more robust recovery practices.

Highlights

• Documentation Update: The recovery_window parameter in the initWallet example within the remote signing documentation has been increased from 2500 to 31000.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• docs/remote-signing.md
  • Updated the recovery_window value in the initWallet example from 2500 to 31000.

Activity

• No specific pull request activity (comments, reviews, etc.) has been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the recovery_window value in an example script within the remote signing documentation. My review identifies an inconsistency in the same document where an example command output still refers to the old default value. This should be updated for consistency.

_{Note: Security Review has been skipped due to the limited scope of the PR.}

[lightninglabs-deploy]

🟢 PR Severity: LOW

Automated classification | 1 file | 2 lines changed

🟢 Low (1 file)

• `docs/remote-signing.md` - documentation file under docs/*

Analysis

This PR makes a minimal documentation change (1 addition, 1 deletion) to docs/remote-signing.md. Documentation files under docs/* are classified as LOW severity. No code, protocol logic, or security-sensitive paths are touched. There are no bump conditions triggered (only 1 non-test file, only 2 lines changed).

---

_{To override, add a `severity-override-{critical,high,medium,low}` label.}

[yyforyongyu]

Thanks for the PR - could you provide more context on why this change, and follow the contribution guideline to learn how to create the commit msgs?

[BlueeeMoon]

Thanks for the PR - could you provide more context on why this change, and follow the contribution guideline to learn how to create the commit msgs?

Yes, I tested the default recovery window in a very old Lightning wallet. After a lot of tests, with the default value, I notice the wallet dont recover all my funds, so I increase it more and more and with this new value of recovery window I finally recover it all.

My Seed birthday is created around the block height 647501.

My proposal is increase the default value for the LND new versions to try to read all the funds avaiable in any wallet.