Skip to content

sample-envの変更 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryotamoriyama wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sample-envの変更 #26

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfd4e52
Modify .env
Sep 10, 2018
d2135ca
Add goutenberg into sample plugin list
Sep 10, 2018
19a1137
Add WP_OPTIONS_SETUP to env-sample for initializing wp_options setup
Sep 11, 2018
fd0912e
Modify content for making PR simply
Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion env-sample
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
# Copy and create ".env" file same directory
MYSQL_ROOT_PASSWORD=password
MYSQL_DATABASE=wordpress

# Only first build
WP_ROOT=/var/www/html
WP_URL=http://localhost
WP_VERSION=4.8.2
WP_VERSION=4.9.8
Copy link
Contributor

@ktogo ktogo Sep 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ああごめん…書き方悪かったかな、
これもまた別PRでお願いします！

どっちも依存関係のない修正 (=別々の機能) なので、
こういうものは基本的に個別のPRにしましょう。

というのも、仮に18行目の修正をRevertしなきゃならなくなったとき、
こっちの修正も一緒にRevertされることになっちゃうからです。

WP_DB_PREFIX=wp_
WP_ADMIN_USER=root
WP_ADMIN_PASSWORD=root
WP_ADMIN_EMAIL=root@example.com
WP_CURRENT_THEME=sampletheme

# Install Plugins
# Sample:
# rewrite-rules-inspector addquicktag intuitive-custom-post-order gutenberg
WP_INSTALL_PLUGINS=query-monitor wordpress-seo