Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

molly: fix executing of method close #4

Merged
merged 1 commit into from
May 27, 2024

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented May 22, 2024

  • Fix executing of a close method due to early return
  • Add logging to client methods
  • Fix errors in test examples

Fix #2

@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 9254051751

Details

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.0%) to 93.362%

Changes Missing Coverage Covered Lines Changed/Added Lines %
molly/client.lua 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
molly/client.lua 3 86.59%
molly/tests.lua 4 86.54%
Totals Coverage Status
Change from base Build 9254022448: -1.0%
Covered Lines: 647
Relevant Lines: 693

💛 - Coveralls

- Fix executing of a `close` method due to early return
- Add logging to client methods
- Fix errors in test examples

Fix #2
@ligurio ligurio force-pushed the ligurio/gh-2-fix-executing-close-method branch from 9c53b69 to 5003514 Compare May 27, 2024 11:28
@ligurio ligurio merged commit 69d19e3 into master May 27, 2024
5 checks passed
@ligurio ligurio deleted the ligurio/gh-2-fix-executing-close-method branch May 27, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The close() method is not called
2 participants