Skip to content

Fix/property desc issues#988

Merged
StephGit merged 7 commits intomasterfrom
fix/property-desc-issues
Apr 2, 2026
Merged

Fix/property desc issues#988
StephGit merged 7 commits intomasterfrom
fix/property-desc-issues

Conversation

@StephGit
Copy link
Copy Markdown
Contributor

@StephGit StephGit commented Apr 1, 2026

fixes the issues from #980

@StephGit StephGit requested a review from mburri April 1, 2026 16:23
Copy link
Copy Markdown
Member

@mburri mburri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now but I still think that there is way too much logic in the controllers...

IMHO, The rest endpoints should take the input. Transform it into a command (the command does some input validation) and hands it then to a service or use case the is implemented in AMW_business.

There, exceptions are thrown, e.g. if a resource is not found or some other stuff happens.

I also think that we should move the command into AMW_business. And the service method should just get the command. If you want to do this, you cannot use the DTO in the command - because you cannot (or should not) use stuff from AMW_Rest (the outer ring) in AMW_bussines... (the inner ring)... because depdendencies should only point to inner rings...

@StephGit StephGit merged commit 32d7dd6 into master Apr 2, 2026
1 check passed
@StephGit StephGit deleted the fix/property-desc-issues branch April 2, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants