allow symfony 7 #175
Merged
allow symfony 7 #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Sep 19, 2023
dbu
force-pushed
the
symfony-7
branch
3 times, most recently
from
a201c11
to
9eb3ce7
Compare
|
@jeanmonod symfony 7 has been released. good thing we waited, there was one more method that got a return type declaration in Symfony 7. and not repeating the return type is a fatal error with PHP 8.3 |
|
okay to release? |
|
What is blocking current PR? |
|
@jeanmonod @leorott Can somebody merge this? |
|
Hi all, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please do not merge before symfony 7 is released