Generate certificates via a container #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You did know about this PR #1? Is something of the stuff there also in this PR? |
|
Yes I know of it and didn't implement the features you propose to not "steel" your ideas, I focused only on the generation via a container. If you want I can start integrating PR #1 within this one or the contrary. |
|
Looking more closely at it, i'd say we just merge this and then try to rebase and "fix" #1 |
|
Let's do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ease certificates generation on different OS, I propose to do it via container. I've created a separated repository for the docker image as it could be used on other projects.
Tested on ArchLinux and MacOS.
Important changes
docker.rootCA.crtbutdocker.test.rootCA.crtto avoid possible extension conflicts.External links