[TAS-205] ✨ Add 'Collectable Before' feature #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiJun0827
changed the title
williamchong
requested changes
Aug 18, 2023
components/NFTMint/WriterMessage.vue
Outdated
Comment on lines
222
to
225
| if (!checked) { | ||
| this.$emit('update:collectableBeforeDate', '') | ||
| this.$emit('update-collectable-before-date', '') | ||
| } |
There was a problem hiding this comment.
Would this break if I uncheck then check the checkbox? A date input would be shown, but no collectable-before-date event is fired since no @change has occurred yet
There was a problem hiding this comment.
The field would be reset if the checkbox is unchecked:
2023-08-21.4.44.24.mov
Is this behavior works OK?
There was a problem hiding this comment.
Would the data be wrong if I click next button without clicking in the background first?
There was a problem hiding this comment.
The above actions didn't click the background actually, I think the computed did the job, and the Vue extension UI has a little latency.
williamchong
approved these changes
Aug 21, 2023
|
@williamchong Updated |
williamchong
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on likecoin/likecoin-api-public#506
2023-08-15.7.10.09.mov