[TAS-114] ✨ Add upload only mode #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
williamchong
commented
Sep 7, 2023
williamchong
commented
nwingt
reviewed
Sep 8, 2023
components/IscnRegisterForm.vue
Outdated
Comment on lines
170
to
171
| <Button v-else :text="$t('IscnRegisterForm.button.upload')" preset="secondary" | ||
| @click.native="onUploadOnly"> |
There was a problem hiding this comment.
Suggested change
| <Button v-else :text="$t('IscnRegisterForm.button.upload')" preset="secondary" | |
| @click.native="onUploadOnly"> | |
| <Button | |
| v-else | |
| :text="$t('IscnRegisterForm.button.upload')" | |
| preset="secondary" | |
| @click.native="onUploadOnly" | |
| > |
components/IscnRegisterForm.vue
Outdated
Comment on lines
353
to
364
| <a | ||
| :class="[ | ||
| 'text-[8px]', | ||
| 'underline', | ||
| 'mt-[4px]', | ||
| 'mb-[-12px]', | ||
| ]" | ||
| href="#" | ||
| @click.prevent="showUploadOnly = true" | ||
| > | ||
| {{ $t('IscnRegisterForm.button.uploadOnly') }} | ||
| </a> |
There was a problem hiding this comment.
I believe this button should be moved to the left, as the main action should always remain on the right-most side
Also, this <a/> could be replaced by <Button preset="outline" /> to ensure consistent styling
There was a problem hiding this comment.
I believe this button should be moved to the left, as the main action should always remain on the right-most side
Also, this
<a/>could be replaced by<Button preset="outline" />to ensure consistent styling
Totally missed there are 2 parts of review..
Does this look ok?
| :class="[ | ||
| 'flex', | ||
| 'flex-col', | ||
| 'items-end', |
There was a problem hiding this comment.
Suggested change
| 'items-end', | |
| 'items-end', | |
| 'gap-[12px]', |
components/IscnRegisterForm.vue
Outdated
| @@ -1020,6 +1068,33 @@ export default class IscnRegisterForm extends Vue { | |||
| return undefined | |||
| } | |||
|
|
|||
| async onUploadOnly(): Promise<void> { | |||
| logTrackerEvent(this, 'ISCNCreate', 'ClickSubmit', '', 1); | |||
There was a problem hiding this comment.
Should we distinguish this from the ClickSubmit event in onSubmit()?
nwingt
reviewed
Sep 8, 2023
williamchong
added a commit
that referenced
this pull request
Sep 15, 2023
* ✨ Add upload only mode * 🎨 Fix indentation and remove unused slot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.