Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAS-918] 🚸 Add iscnOwner to stakeholders #435

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

AuroraHuang22
Copy link
Collaborator

截圖 2024-01-09 晚上8 26 35
截圖 2024-01-09 晚上8 26 45

Copy link

AuroraHuang22 added a commit that referenced this pull request Jan 9, 2024
components/IscnRegisterForm.vue Outdated Show resolved Hide resolved
components/IscnRegisterForm.vue Outdated Show resolved Hide resolved
Copy link
Member

@williamchong williamchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep array type if wallet must be array of object

@@ -809,7 +809,7 @@ export default class IscnRegisterForm extends Vue {
thumbnailUrl: string = ''
authorName: string = ''
authorUrl: string[] = []
authorWalletAddress: string[] = []
authorWalletAddress: any = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
authorWalletAddress: any = []
authorWalletAddress: any[] = []

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,7 +1,7 @@
export interface Author {
name: string;
url: string[];
wallet: string[];
wallet: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wallet: any;
wallet: any[];

@williamchong williamchong merged commit e7d2096 into likecoin:main Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants