[TAS-1062]💄 Add ISCN edit bar to the /new page #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AuroraHuang22
commented
Jan 31, 2024
AuroraHuang22
commented
AuroraHuang22
changed the title
AuroraHuang22
added a commit
that referenced
this pull request
Jan 31, 2024
williamchong
requested changes
Jan 31, 2024
components/IscnUploadedInfo.vue
Outdated
| :iscn-id="iscnId" | ||
| :is-show-mint-button="true" | ||
| :is-nft-book="type === 'Book'" | ||
| :should-show-mint-button="true" |
There was a problem hiding this comment.
What is this prop and how is it different from is show mint button above?
There was a problem hiding this comment.
pages/view/_iscnId/index.vue
Outdated
| :iscn-id="iscnId" | ||
| :is-show-mint-button="isShowMintButton" | ||
| :is-nft-book="isNFTBook" | ||
| :mint-queries="mintQueries" |
There was a problem hiding this comment.
What does this do? Can we just get route query in component instead of passing prop?
There was a problem hiding this comment.
AuroraHuang22
added a commit
that referenced
this pull request
Feb 7, 2024
nwingt
reviewed
Feb 7, 2024
components/IscnEditBar.vue
Outdated
Comment on lines
8
to
10
| 'pt-[24px]', | ||
| 'gap-[8px]', | ||
| 'lg:pt-0', |
There was a problem hiding this comment.
If the padding-top is depends on parent, please inject it in parent
There was a problem hiding this comment.
components/IscnEditBar.vue
Outdated
| <div | ||
| :class="[ | ||
| 'flex', | ||
| 'justify-end', |
There was a problem hiding this comment.
I think that in /new, the items should be aligned to the center instead of to the right.
There was a problem hiding this comment.
AuroraHuang22
added a commit
that referenced
this pull request
Feb 7, 2024
nwingt
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.