Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TAS-1217] 🚸 Add default value to stakeholders #440

Merged
merged 4 commits into from
Feb 16, 2024
Merged

[TAS-1217] 🚸 Add default value to stakeholders #440

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54cf20f
🚸 Add default value to stakeholders
AuroraHuang22 Feb 15, 2024
1f52588
🎨 Use default info when likerid not found
AuroraHuang22 Feb 16, 2024
4474a88
🎨 Handle default info when user data is unavailable
AuroraHuang22 Feb 16, 2024
7a04a19
Merge branch 'main' into feature/stakeholder
williamchong Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 40 additions & 29 deletions components/IscnRegisterForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,7 @@ import { estimateISCNTxGasAndFee, formatISCNTxPayload } from '~/utils/cosmos/isc
import { ISCN_GAS_MULTIPLIER } from '~/constant';
import {
getLikerIdMinApi,
getUserInfoMinByAddress,
API_POST_NUMBERS_PROTOCOL_ASSETS,
} from '~/constant/api';
import { getAccountBalance } from '~/utils/cosmos'
Expand Down Expand Up @@ -1114,38 +1115,48 @@ export default class IscnRegisterForm extends Vue {
}

async mounted() {
if (this.epubMetadata) {
this.name = this.epubMetadata.title;
this.description = this.extractText(this.epubMetadata.description);
this.author.name = this.epubMetadata.author;
this.author.authorDescription = 'Author'
this.language = this.epubMetadata.language
this.tags = this.epubMetadata.tags
this.thumbnailUrl = this.formatArweave(this.epubMetadata.thumbnailUrl) as string
if (this.author.name) {
this.authors.push(this.author)
this.uploadStatus = 'loading'

if (this.epubMetadata) {
this.name = this.epubMetadata.title;
this.description = this.extractText(this.epubMetadata.description);
this.author.name = this.epubMetadata.author;
this.author.authorDescription = 'Author'
this.language = this.epubMetadata.language
this.tags = this.epubMetadata.tags
this.thumbnailUrl = this.formatArweave(this.epubMetadata.thumbnailUrl) as string
if (this.author.name) {
this.authors.push(this.author)
}
}
}
if (this.address) {
const iscnOwner = {
name: this.$t('iscn.meta.stakeholders.name.placeholder') as string,
wallet: [{
content: this.address,
id: 1,
type: 'like',
isOpenOptions: false,
}],
url: [],
likerId: '',
authorDescription: 'ISCN owner',

if (this.address) {
try {
const { data } = await this.$axios.get(
getUserInfoMinByAddress(this.address),
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this throw 404 error, skipping the whole iscnOwner block if the address does not have likeId?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Use default info when likerid not found

const iscnOwner = {
name: data?.displayName || this.address,
wallet: [{
content: this.address,
id: 1,
type: 'like',
isOpenOptions: false,
}],
url: [],
likerId: data?.user || '',
authorDescription: data?.description || 'Publisher',
}
this.authors.push(iscnOwner)
} catch (error) {
// eslint-disable-next-line no-console
console.error(error)
}
}
this.authors.push(iscnOwner)
// ISCN Fee needs Arweave fee to calculate
await this.calculateISCNFee()
this.uploadStatus = ''
}
this.uploadStatus = 'loading'
// ISCN Fee needs Arweave fee to calculate
await this.calculateISCNFee()
this.uploadStatus = ''
}

addContentFingerprint() {
this.customContentFingerprints.push(this.contentFingerprintInput)
Expand Down
Loading