-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TAS-1096]🚸 Revamp field order & UI for ISCN registration #444
Conversation
components/SameAsFieldList.vue
Outdated
if (parts.length === 1) { | ||
return fullFilename | ||
} | ||
return parts.slice(0, -1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to join('.')
it back? Also better to define the return type in function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we prefer having ;
at end of line or not?
other settings
sectionsameAs section
other settings - book
other settings - not book