[TAS-2030] 💄 Add inLanguage field for book #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AuroraHuang22
commented
Aug 27, 2024
AuroraHuang22
commented
AuroraHuang22
added a commit
that referenced
this pull request
Aug 27, 2024
williamchong
requested changes
Aug 28, 2024
components/IscnRegisterForm.vue
Outdated
Comment on lines
869
to
871
| get defaultLanguage() { | ||
| return this.epubMetadata?.language || 'zh' | ||
| } |
There was a problem hiding this comment.
Should set this.language as defaultLanguage on mounted()
There was a problem hiding this comment.
Also would be nice if we can set default as en or zh according to if we have non-ascii charater in title or description
There was a problem hiding this comment.
Use watch to detect name & description language for book.
AuroraHuang22
added a commit
that referenced
this pull request
Aug 30, 2024
AuroraHuang22
force-pushed
the
feature/in-language
branch
from
6af5f50
to
f01d618
Compare
williamchong
requested changes
Sep 2, 2024
components/IscnRegisterForm.vue
Outdated
| @@ -850,6 +866,17 @@ export default class IscnRegisterForm extends Vue { | |||
| return 'CreativeWork' | |||
| } | |||
|
|
|||
| get defaultLanguage() { | |||
| const containsChinese = (str: any) => /[\u4E00-\u9FFF\u3400-\u4DBF\uF900-\uFAFF]/.test(str); | |||
There was a problem hiding this comment.
Suggest to just simply check for all ascii/alphanumeric for English and avoid unicode logic
There was a problem hiding this comment.
AuroraHuang22
added a commit
that referenced
this pull request
Sep 2, 2024
williamchong
reviewed
Sep 2, 2024
components/IscnRegisterForm.vue
Outdated
| get defaultLanguage() { | ||
| const containsOnlyASCII = (str: string) => /^[ -~]*$/.test(str); | ||
|
|
||
| const isEpubInChinese = this.epubMetadata?.language === 'zh'; |
There was a problem hiding this comment.
Should we respect if epub metadata language is explicitly set to en?
There was a problem hiding this comment.
AuroraHuang22
added a commit
that referenced
this pull request
Sep 3, 2024
williamchong
approved these changes
Sep 3, 2024
nwingt
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.